Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support lagoon.sh idling changes in ssh #3767

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 10, 2024

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

When aergia finally moves into uselagoon and lagoon-remote from amazeeio. The labels/annotations being renamespaced will mean that idling.amazee.io will stop working. This prioritises idling.lagoon.sh.

This will just mean that until aergia fully moves into lagoon-remote, two calls will need to be made to check if an environment is idled as idling.lagoon.sh will not exist yet.

This is just laying groundwork for future changes.

ssh-portal will also need refactoring

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense

@tobybellwood tobybellwood merged commit 85f3698 into main Sep 2, 2024
1 check passed
@tobybellwood tobybellwood deleted the ssh-unidling-refactor branch September 2, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants