refactor: support lagoon.sh idling changes in ssh #3767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
When
aergia
finally moves into uselagoon andlagoon-remote
from amazeeio. The labels/annotations being renamespaced will mean thatidling.amazee.io
will stop working. This prioritisesidling.lagoon.sh
.This will just mean that until aergia fully moves into lagoon-remote, two calls will need to be made to check if an environment is idled as
idling.lagoon.sh
will not exist yet.This is just laying groundwork for future changes.
ssh-portal will also need refactoring