build: Update golang used in services to 1.22 #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
approved these changes
Jul 28, 2024
tobybellwood
force-pushed
the
testing/golang_update
branch
from
c2dd1d3 to
ce9e1b5
Compare
shreddedbacon
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the golang version in use by the lagoon services to 1.22
The following issues were discovered:
github.com/Khan/genqlient v0.3.0module in services/workflows could not be updated due to a change in the MakeRequest structure in v0.5.0 that will require attentiongit.luolix.top/cheshir/go-mq/v2module in services/workflows fails vet with a "passes lock by value" error - unsure about thisk8s.io/*modules in task-activestandby fail tests (around IngressList structure) when updated to 1.30.x - this will require attention (I think to modify the expected result JSON)edit: raised the above issues for tracking in #3783