Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for only matching fingerprint on key lookups #3784

Merged
merged 3 commits into from
Aug 5, 2024
Merged

fix: check for only matching fingerprint on key lookups #3784

merged 3 commits into from
Aug 5, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Jul 30, 2024 •
edited
Loading

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Updates the query when checking for ssh keys to query for the specific fingerprint, rather than all keys.

Also includes a minor logic fix on the platformowner/viewer permission check for groups

@shreddedbacon shreddedbacon added this to the 2.20.1 milestone Jul 31, 2024
@shreddedbacon shreddedbacon changed the title fix: add a where for the fingerprint to prevent uncessesary data retreival fix: check for only matching fingerprint on key lookups Jul 31, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review August 2, 2024 07:07
tobybellwood
tobybellwood approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working, LGTM

@tobybellwood tobybellwood merged commit d61b7d4 into main Aug 5, 2024
1 check passed
@tobybellwood tobybellwood deleted the fix-sshkey-lookup branch August 5, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.20.1
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood