Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: exclude any disabled projects from polysite count #3787

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

#3668 introduced grouping deployments of polysites under a bulk label. This is a small fix to exclude projects where deployments are disabled from being evaluated under the count.

@shreddedbacon shreddedbacon added this to the 2.20.1 milestone Aug 5, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review August 6, 2024 03:23
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple enough change. LGTM

@tobybellwood tobybellwood merged commit 571456b into main Aug 6, 2024
1 check passed
@tobybellwood tobybellwood deleted the polysite-disabled-projects branch August 6, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants