feat: add lagoon-ui-oidc client #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
ui-oidc-client
branch
from
95335ac to
8bff110
Compare
tobybellwood
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
This creates a copy of the
lagoon-uiclient calledlagoon-ui-oidcthat has public authentication disabled. This client will eventually be used by the next UI version, while leaving the existing client in place for the current UI so that both versions of the UI could be used while development is undertaken, with the eventual goal of the originallagoon-uiclient going away.The charts will need to be updated to include support for configuring the secret for this client with this variable
KEYCLOAK_LAGOON_UI_OIDC_CLIENT_SECRET