Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow platform to delete systemwide tasks #3825

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: allow platform to delete systemwide tasks #3825

merged 1 commit into from
Oct 22, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Fix the ability for platform owner to delete systemwide tasks

@shreddedbacon shreddedbacon added this to the 2.22.0 milestone Oct 14, 2024
@shreddedbacon shreddedbacon requested a review from bomoko October 14, 2024 03:55
@shreddedbacon shreddedbacon marked this pull request as ready for review October 14, 2024 04:39
tobybellwood
tobybellwood approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me - sensible update of existing permissions.

@tobybellwood tobybellwood merged commit 3ca81ad into main Oct 22, 2024
1 check passed
@tobybellwood tobybellwood deleted the delete-systemwide-advtask branch October 22, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

@bomoko bomoko Awaiting requested review from bomoko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood