Update task status to "failed" when services error out #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schnitzel
added a commit
that referenced
this pull request
Feb 26, 2019
Update task status to "failed" when services error out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The current task system uses existing openshift pods as a source for creating new openshift job pods. If the pods are idled, the task system will not find a running pod of the correct service and the
openshiftjobservice will bail out. This could leave the task in "active" status forever.This PR updates the status of the task to "failed" when this, or other final errors, occur.
Changelog Entry
Bugfix - Update task status to "failed" when services error out (#896)
Closing issues
closes #896