Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use queued build status for queued builds #196

Merged
merged 4 commits into from
Mar 7, 2023
Merged

chore: use queued build status for queued builds #196

merged 4 commits into from
Mar 7, 2023

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Now that uselagoon/lagoon#3351 has been merged, this changes the controller to send the queued status for queued builds.

@shreddedbacon shreddedbacon marked this pull request as ready for review February 2, 2023 23:59
@shreddedbacon
Copy link
Member Author

shreddedbacon commented Feb 3, 2023 •
edited
Loading

This has a requirement of Lagoon v2.12.0 to work, so will try to coordinate this some how

EDIT: Now has version check

@shreddedbacon shreddedbacon force-pushed the queued-status branch 2 times, most recently from ce8c3a7 to ea4952f Compare February 20, 2023 06:12
@shreddedbacon shreddedbacon requested a review from bomoko March 6, 2023 23:31
bomoko
bomoko approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added one more comment, but happy happy

internal/helpers/helpers.go Outdated Show resolved Hide resolved
@shreddedbacon shreddedbacon merged commit 2919437 into main Mar 7, 2023
@shreddedbacon shreddedbacon deleted the queued-status branch March 7, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomoko bomoko bomoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @bomoko