-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ToggleInput #672
add ToggleInput #672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a "on" story with isChecked={true}
so we can track our color visually w/ Chromatic? (I guess also off / disabled, and on / disabled as well, but it starts to feel like overkill). Just not sure where to draw the line with visual test coverage vs making too many stories for storybook interface, so your call on that.
Also a 'labelLeft' story would be nice just to have that easily discoverable, but also not required.
closes #671
Bringing the
ToggleInput
into the Design System.Nat is currently doing a design review:
https://www.chromatic.com/build?appId=62d040e741710e4f085e0647&number=33