Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-decoration none on DropdownItem hover #706

Merged
merged 1 commit into from
Aug 15, 2022
Merged

text-decoration none on DropdownItem hover #706

merged 1 commit into from
Aug 15, 2022

Conversation

jasonbasuil
Copy link
Collaborator

closes #705

💅 when used on RS, the DropdownItem hover state gets overridden by body.scss which underlines all a tags on hover so just doing this here.

@jasonbasuil jasonbasuil merged commit 85e268b into develop Aug 15, 2022
@jasonbasuil jasonbasuil deleted the dropdown-item/UIDS-705-no-text-decoration-on-hover branch August 15, 2022 16:28
jasonbasuil pushed a commit that referenced this pull request Aug 15, 2022
@github-actions
Merge release/1.33.0 into main branch (#709)
e6ee42a 
* change Select option color to $ux-gray-900 (#707)

* text-decoration none on DropdownItem hover (#706)

* add unstyled variant to DropdownToggle (#704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rroppolo rroppolo rroppolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DropdownItem no text-decoration on hover
2 participants
@jasonbasuil @rroppolo