Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower pulls down duplicate libraries #727

Closed
naeazach opened this issue Jun 3, 2017 · 5 comments
Closed

bower pulls down duplicate libraries #727

naeazach opened this issue Jun 3, 2017 · 5 comments
Milestone

Comments

@naeazach
Copy link

naeazach commented Jun 3, 2017

When adding a bower package, the installdoesn't seem to be checking if the items package's dependant items are installed in one of the other sprinkles. Here is my bower file:
{ "name": "site-assets", "version": "0.0.1", "homepage": "https://github.com/userfrosting", "authors": [ "zach" ], "moduleType": [ "node" ], "license": "MIT", "ignore": [ "**/.*", "node_modules", "bower_components", "assets/vendor", "examples", "demo-resources", "demo", "test", "tests" ], "dependencies": { "jqueryui-touch-punch" : "*", "fontIconPicker":"^2.0.0" } }

@Silic0nS0ldier Silic0nS0ldier added the wontfix This will not be worked on label Jun 3, 2017
@Silic0nS0ldier
Copy link
Member

This is a known issue, and any resolution would be a major undertaking. Since this presents no issue, its low priority. That said, I'll let you know if there are any developments.

@alexweissman
Copy link
Member

🗿 ❄️

@alexweissman alexweissman added this to the 4.1.x milestone Jun 18, 2017
@Silic0nS0ldier
Copy link
Member

As part of the pending introduction of NPM support for frontend assets (which requires a number of changes to be conducted to be efficient), this issue will soon be fixed. (still a major undertaking, but now it has the support of additional issues)

@Silic0nS0ldier Silic0nS0ldier removed the wontfix This will not be worked on label Jul 7, 2017
@Silic0nS0ldier Silic0nS0ldier modified the milestones: 4.x, 4.1.x Jul 7, 2017
@Silic0nS0ldier
Copy link
Member

I've got this issue resolved in a developmental UF 4.0 branch (4.0-feature-npm-assets).

By the next release (at least for UF4.0), all vendor assets will live in app/assets/bower_components and app/assets/node_modules.

When in default (or dev) mode, assets pulled from these locations will have assets-raw/vendor-bower and assets-raw/vendor-npm.

When installing vendor assets, console output will be similar to the following:
image

@alexweissman
Copy link
Member

Does seem to make more sense than each Sprinkle having its own assets/vendor directory!

Silic0nS0ldier added a commit that referenced this issue Dec 13, 2017
…sc. changes

- Duplicate frontend vendor packages are no longer downloaded (fixes #727).
- Detect dependency conflicts between frontend vendor packages.
- Fixed Portugese translations.
- Improve URL reliability under docker.
- Stopped bower from complaining about sudo when using containers like docker.
- Deprecated `assetLoader` service.
@Silic0nS0ldier Silic0nS0ldier modified the milestones: 4.x, 4.2.0 Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants