chore: use custom vuetify styles vite plugin #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
commented
Aug 24, 2024
userquin
commented
Aug 24, 2024
plugins/vuetify.ts
Outdated
| const target = resolution.id.replace(/\.css$/, '.sass') | ||
| tempFiles.set(target, isNone | ||
| ? '' | ||
| : `@use "${normalizePath(configFile)}"\n@use "${resolution.id}"` |
There was a problem hiding this comment.
I think we don't need to normalize config file
There was a problem hiding this comment.
In fact with the Vite file:// resolver we should use:
`@use "${pathToFileURL(configFile).href}"\n@use "${pathToFileURL(resolution.id).href}"`
There was a problem hiding this comment.
sass needed a leading slash on windows last time I checked: vuetifyjs/vuetify-loader#274
There was a problem hiding this comment.
@KaelWD this branch using custom file:// loader from https://pkg.pr.new/vite@561b940
Check vitejs/vite#17909
There was a problem hiding this comment.
previous screenshot from my Windows laptop; working with and without pathToFileURL(...).href
userquin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.