Skip to content

Commit

Permalink
cc s3api: fix clang-tidy
Browse files Browse the repository at this point in the history
* fixing clang-tidy errors

Tests: протестировано CI

Pull Request resolved: #738
commit_hash:d71d683ec6155e0fcdb47be1aefd130f81e546ca
  • Loading branch information
v-for-vandal authored and fdr400 committed Oct 30, 2024
1 parent 06eb1e8 commit afbfe37
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
6 changes: 4 additions & 2 deletions libraries/s3api/include/userver/s3api/clients/s3api.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ class Client {

virtual ~Client() = default;

// NOLINTBEGIN(google-default-arguments)

virtual std::string PutObject(
std::string_view path,
std::string data,
Expand Down Expand Up @@ -166,11 +168,11 @@ class Client {

virtual std::vector<std::string> ListBucketDirectories(std::string_view path_prefix) const = 0;

// TODO: See if we can get rid of it
// TODO: Or rename it as UpdateConnectionConfig
virtual void UpdateConfig(ConnectionCfg&& config) = 0;

virtual std::string_view GetBucketName() const = 0;

// NOLINTEND(google-default-arguments)
};

using ClientPtr = std::shared_ptr<Client>;
Expand Down
7 changes: 2 additions & 5 deletions libraries/s3api/src/s3api/s3api_methods.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

USERVER_NAMESPACE_BEGIN

namespace s3api {
namespace api_methods {
namespace s3api::api_methods {

Request PutObject(
std::string_view bucket,
Expand Down Expand Up @@ -117,8 +116,6 @@ Request CopyObject(
return req;
}

} // namespace api_methods

} // namespace s3api
} // namespace s3api::api_methods

USERVER_NAMESPACE_END

0 comments on commit afbfe37

Please sign in to comment.