limit json depth to 128 #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/ |
|
Tests are failing! Please look at userver/universal/src/formats/json/impl/types_impl.cpp (yes, a tricky one) how rapidjson's Value must be destroyed to avoid stack overflow. |
Will do, thanks for the tip! |
moki
force-pushed
the
moki-codes/limit-json-depth-to-128
branch
from
fff4a82 to
5edab34
Compare
moki
force-pushed
the
moki-codes/limit-json-depth-to-128
branch
from
5edab34 to
c5edf01
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #450