Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strange enum from ServiceControl #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Apr 8, 2016

Fix for #426

@@ -207,13 +207,8 @@ public boolean isConnected() {
return Utility.isConnected(mContext);
}

public enum SchedulerInstance {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make the Scheduler a Singleton. More thread-safety this way.

Copy link
Contributor Author

@alxndrsn alxndrsn Apr 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, I obviously missed the singletoning - sorry!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More thread-safety this way.

Surely something's thread-safe or it's not - the area between the two is scary (and not thread-safe)!

@eyedol
Copy link
Collaborator

eyedol commented Apr 27, 2016

@alxndrsn What's the status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants