Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directives - Move unshared from common module #1699

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

Ifycode
Copy link
Member

@Ifycode Ifycode commented Aug 12, 2021

This pull request makes the following changes

Note

These tables/info below are based on the splitting of code into map, data, activity and settings done during @Ifycode's internship (May - August 2021). Table may need to be updated if anything in the those 4 modules change.

Shared directives

Map Data Activity Settings Modebar Directives
  • loading-dots-button
  • embed-only
  • language-switch
  • role-selector
  • translations-switch
  • add-language
  • listing-toolbar
Map Data Activity Settings Modebar Directives Common files found in
  • file-upload
first-time-config
  • layout-class
verifier

Not shared directives

Map Data Activity Settings Modebar Directives Moved
  • loading-dots
  • category-selector
  • filter-role
  • filter-searchbar
  • color-picker
  • overflow-toggle

Remove or move these ones below?

  • add-category (doesn't look used)
  • iconpicker (doesn't look used)
  • publish-selector (doesn't look used)
  • focus (how & where is this used?)
  • modal-body (can only find class-name)
  • first-time-config (where to put this or remove?)
index.html Directives
  • ush-mainsheet-container
  • ush-modal-container
  • ush-demo-slider
index.html Directives Common files found in
  • ush-slider
modal-container

Testing checklist

  • Files not shared are moved out of common module to the respective module found in
  • I certify that I ran my checklist

Ping @ushahidi/platform

@Ifycode Ifycode changed the title Move loading-dots to settings Common module - Move unshared files Aug 12, 2021
@Ifycode Ifycode marked this pull request as draft August 12, 2021 02:10
@Ifycode Ifycode changed the title Common module - Move unshared files Common module - Move unshared directives Aug 15, 2021
@Ifycode Ifycode marked this pull request as ready for review August 15, 2021 08:59
@Ifycode Ifycode requested a review from Angamanga August 15, 2021 09:00
@Ifycode Ifycode changed the title Common module - Move unshared directives Directives - Move unshared from common module Aug 15, 2021
@Ifycode
Copy link
Member Author

Ifycode commented Aug 15, 2021

Ready for review @Angamanga

Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🎉

@Angamanga Angamanga merged commit 135feb9 into ushahidi:feature/migration Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants