Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CIs #607

Merged
merged 127 commits into from
Apr 8, 2019
Merged

Update CIs #607

merged 127 commits into from
Apr 8, 2019

Conversation

guyer
Copy link
Member

@guyer guyer commented Oct 23, 2018

This pull request will (hopefully)

Addresses #564

@guyer guyer changed the title Add CircleCI badge [WIP] Add CircleCI badge Oct 24, 2018
@guyer guyer changed the title [WIP] Add CircleCI badge Update CIs Oct 24, 2018
@guyer guyer changed the title Update CIs WIP: Update CIs Oct 24, 2018
@guyer guyer requested review from tkphd and wd15 April 7, 2019 16:41
@guyer
Copy link
Member Author

guyer commented Apr 7, 2019

Fixes #564
Fixes #530

.travis.yml Show resolved Hide resolved
@@ -66,14 +66,19 @@ Recommended Method

.. attention::

Note, this does not work on Windows. On that platform, you should be able to do::
Note, this does not work on Windows x86, as conda-forge_ no longer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps clarify that it will work for Windows x86_64, it's just the 32-bit flavor that's deprecated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will clarify.

of the utilities that manage packages and their dependencies independently
of the system package manager and the system directories. These utilities
include conda_, Stow_, Virtualenv_ and zc.buildout_, amongst others.
Conda_ is the only one of these we have the resources to support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Nix count?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not if I can help it

Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three CI services show green lights, and successfully run all tests. Nicely done, @guyer!

INSTALLATION.rst Show resolved Hide resolved
INSTALLATION.rst Show resolved Hide resolved
Copy link
Contributor

@wd15 wd15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly change INSTALLATION.rst again to remove some of the old stuff.

@guyer guyer requested a review from wd15 April 8, 2019 19:56
@wd15
Copy link
Contributor

wd15 commented Apr 8, 2019

Remember to squash and merge on this one

@wd15
Copy link
Contributor

wd15 commented Apr 8, 2019

@guyer will move suggestions to another issue

@guyer guyer mentioned this pull request Apr 8, 2019
3 tasks
@guyer
Copy link
Member Author

guyer commented Apr 8, 2019

Documentation issues raised in review will be addressed in #631

@guyer guyer merged commit 4c5585c into usnistgov:develop Apr 8, 2019
@guyer guyer deleted the updateci branch April 9, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants