Disable TVTK tests if its prerequisites aren't met #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the test failures. They're addressed on #721. |
wd15
reviewed
Nov 9, 2020
| # With Python 2.7 end-of-life, bitrot has set in. While tvtk is | ||
| # available from conda-forge, it can raise an exception when it | ||
| # internally does this import. | ||
| from collections.abc import Sequence |
There was a problem hiding this comment.
I don't fully understand why the import is required. If it fails then let it fail and the user gets a warning that it isn't available. How does the extra import impact that?
There was a problem hiding this comment.
If we do that then running CI on Python 2.7 is pointless. We'll never get clean pull requests, even though we don't really care about TVTK failures and we know why they happen.
There was a problem hiding this comment.
I get it. Tvtk always imports, but fails during the run stage so you're trying to make the failure happen during the import stage.
wd15
approved these changes
Nov 9, 2020
tkphd
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.