Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oscal-cli validation rule for ssp/system-implementation/components/protocols/port-ranges/transport #276

Open
2 tasks
Telos-sa opened this issue Aug 22, 2024 · 4 comments
Labels
enhancement The issue adds a new feature, capability, or artifact to the repository. User Story The issue is a user story for a development task.

Comments

@Telos-sa
Copy link

User Story:

As an OSCAL {stakeholder}, I want to pass a token styled data, and it still validate as long as the token format is met.

Goals:

Adjust the requirements and validations for transport token, to allow either TCP/tcp UDP/udp as either format would be an accepted token format

Dependencies:

Updating the SSP model reference on the Nist Site. Updating metaschema to support all token formats for each token, updating validation.

Acceptance Criteria

  • All readme documentation affected by the changes in this issue have been updated.
  • [ X ] A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}

@Telos-sa Telos-sa added enhancement The issue adds a new feature, capability, or artifact to the repository. User Story The issue is a user story for a development task. labels Aug 22, 2024
@iMichaela
Copy link
Contributor

iMichaela commented Aug 22, 2024

@Telos-sa - This is an OSCAL schema issue not OSCAL content. Can you please move the issue to the https://github.com/usnistgov/OSCAL repo? . I could do it myself, but it would not preserve the issue ownership. With the said - is the capitalization of the allowed values TCP and UDP such a difficult issue that it cannot be addressed programmatically and requires a schema change? Maybe there is more background info related to this issue that we could benefit from better understanding it?

Also important to note that oscal-cli supports the OSCAL schemas so the change is NOT in oscal-cli
Thank you.

@Telos-sa
Copy link
Author

Thanks for the quick response!

I think the root of the request, at least for core metaschema validations, would be for all accepted token formats to be standardized.

User Story: CSP developing legacy content will not have data in tokens. Xacta converts all data elements to token format as single rule, all lower case, replacing spaces with "-". This formula seems to work in all other instances of token usage. For this field, we are creating an additional function for findings token elements that have a different lettercase requirement.

It is not difficult programmatically, but it is a difference that may catch other CSPs, that were converting strings to tokens based on formatting requirements, that they need to be aware when validating, there is also a lettercase check.

@iMichaela
Copy link
Contributor

@Telos-sa - Thank you for the additional explanation. This is still not an oscal-content issue. Are you OK if I move it to the correct repo?

@Telos-sa
Copy link
Author

Telos-sa commented Aug 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue adds a new feature, capability, or artifact to the repository. User Story The issue is a user story for a development task.
Projects
Status: Needs Triage
Development

No branches or pull requests

2 participants