-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIST SP800-53 catalog with labels restored #238
Conversation
….2.1 version Committer: Michaela Iorga <michaela.iorga@nist.gov>
In the latest OSCAL version of the NIST SP 800-53 (v5.1.1+u4), each catalog has:
This was done to align with he CPRT data and promote zero-padded control IDs until v6 when we will be able to break the backwards compatibility and add those zero-padded IDs as OSCAL control IDs as well. NOTE: This decision was made in collaboration with the community members and per @david-waltermire note that RMF team's lead is not prescriptive with respect the the accuracy of the zero-padded control IDs' representation as OSCAL IDs or as alternative identifiers. The dialog and community's input is available on OSCAL/Lobby
This was done to support the backwards compatibility for tools relying on the such labels fro generating human-friendly versions of the catalog. |
The PR is ready for community's review, in addition to NIST team's review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR restores the non-zero-padded control labels, removing the alt-identifier properties. I reviewed a diff of the catalog and it looks good. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you
[CALL TO ACTION]: The OSCAL content PR #238 updating the NIST SP 800-53 v5.1.1 is proposing restoring of the The PR will be merged at the end of the month if no comments/objections are received. |
Committer Notes
The PR fixes #237 by restoring the
prop/@name="label"
for backwards compatibility with previous oscal versions of the catalog. Additionally, the PR fixes #72 by removing the self-reference error in SC-12 to align with the corrected CPRT data.All Submissions:
Changes to Core Features: