Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no composition derivatives in get_ATrhoXi_runtime #144

Closed
ianhbell opened this issue Jul 23, 2024 · 3 comments
Closed

Allow no composition derivatives in get_ATrhoXi_runtime #144

ianhbell opened this issue Jul 23, 2024 · 3 comments
Milestone

Comments

@ianhbell
Copy link
Collaborator

See

#define get_ATrhoXi_runtime_combinations \
X(0,0,1) \
X(0,0,2) \
X(0,0,3) \
X(1,0,1) \
X(1,0,2) \
X(1,0,3) \
X(0,1,1) \
X(0,1,2) \
X(0,1,3) \
X(2,0,1) \
X(2,0,2) \
X(2,0,3) \
X(1,1,1) \
X(1,1,2) \
X(1,1,3) \
X(0,2,1) \
X(0,2,2) \
X(0,2,3)

For you @Matthew-Boyd

@Matthew-Boyd
Copy link

Could you enable X(0,0,0) too? This would simplify calculating the reduced Helmholtz using dimensionless parameters by not having to back-calculate them from T and rho (via casts to get Tr and rhor).

@ianhbell
Copy link
Collaborator Author

Yeah, one sec. I vaguely recall there was a reason why that was a bad idea, but I don't remember what it was. Maybe it was elsewhere now that I think about it.

ianhbell added a commit that referenced this issue Jul 24, 2024
ianhbell added a commit that referenced this issue Jul 24, 2024
@ianhbell
Copy link
Collaborator Author

I needed a separate approach for 0,0,0, but I sorted it. You should be good to go

@ianhbell ianhbell added this to the 0.21.0 milestone Jul 25, 2024
ianhbell added a commit that referenced this issue Jul 30, 2024
See #144. Still a problem with methanol and fluorine since they use the real critical temperature not the reducing temperature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants