Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a and b parameters from the papers of Liang for PC-SAFT #134

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Add a and b parameters from the papers of Liang for PC-SAFT #134

merged 5 commits into from
Jul 3, 2024

Commits on Jul 3, 2024

  1. Add two more PC-SAFT universal parameter sets from Liang 

    And refactor loading of the coefficients to allow it
    @ianhbell
    ianhbell committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e64655b View commit details
    Browse the repository at this point in the history

  2. Fix types for Arrays in new PCSAFT

    @ianhbell
    ianhbell committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a0f9643 View commit details
    Browse the repository at this point in the history

  3. keep a and b as default parameters 

    If kmat is provided they are required to be implemented
    @ianhbell
    ianhbell committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2c49895 View commit details
    Browse the repository at this point in the history

  4. Update the tests where kmat is provided 

    And also when not
    @ianhbell
    ianhbell committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    55573a1 View commit details
    Browse the repository at this point in the history

  5. Docs and schema for new a & b

    @ianhbell
    ianhbell committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    69ffc3d View commit details
    Browse the repository at this point in the history