Add combination of multifluid and AC models (Wilson, COSMO-SAC) #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be working properly, notebook looks decent
…ucing function And another flawed approach
Other COSMO-SAC variants are possible, would require a bit of refactoring
Was changed after the preprint, fixed also in CoolProp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the approach of https://doi.org/10.1016/j.fluid.2018.04.015 and https://doi.org/10.1016/j.fluid.2018.08.004
Also includes the Wilson model as well as another model for AC for binary mixtures at constant temperature (for much faster calculations, COSMO-SAC is very slow)
Closes #151
Validation against the implementation in TREND