-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with amazonaws.com #16
Comments
same issue (s3.amazonaws.com) :(
(on php 8.1) |
@UnveilTech : I tried all 3 implementations with
What exactly fails with NULL? (on PHP 8.1.2 and perl 5, version 34) |
@Pascal76: as This regdom-lib allows to detect registered domain names equal to the subdomain below a public suffix.
Looking at the request of an Amazon employee in publicsuffix/list#105 to add @lawells: you were the one that requested publicsuffix/list#105 back in 2016. Could you please clarify why Amazon had the need to have these detailed *.amazonaws.com public suffixes published? |
public function validDomainPart($domPart) { There should be a check to avoid NULL for $domPart |
I just added it in ee64e44 |
Hi, $szDom is NULL, it should be "amazonaws.com" bye Fred |
$szHost = "kinesis.us-east-1.amazonaws.com"; |
$szDom is "kinesis.us-east-1.amazonaws.com" according to the explanation in #16 (comment). Maybe it would be more precise to differ between What's your use-case for getRegisteredDomain(...) ? |
What's your use-case for getRegisteredDomain(...) ? $szDom = getRegisteredDomain("kinesis.us-east-1.amazonaws.com"); |
Are you sure you're using the latest implementation? $registeredDomain = getRegisteredDomain("kinesis.us-east-1.amazonaws.com", $tldTree); |
Hi, bye Fred |
@UnveilTech : yes, sure. Can you confirm that my explanation for this issue in #16 (comment) makes the problem clear? |
Hi,
is that normal that none of amazonaws.com hosts are found ?
ex: kinesis.us-east-1.amazonaws.com
each time it gives NULL
bye Fred
The text was updated successfully, but these errors were encountered: