-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplatform support #208
Conversation
@Sanlorng |
@Sanlorng
I used to specify the Compose Compiler version in build.gradle as follows, but is it unnecessary with KMP?
|
I remove the |
The compile error was fixed,you can fetch the branch and compile again. |
@Sanlorng In addition, could you tell me how to run the desktop sample app? |
@Sanlorng
|
@Sanlorng |
I need find a Windows Pad to test it. |
,The simple way is clicking the run button in the left of |
I've tried it in the RDP with Touch mode, it doesn't works. and then i search keyword |
Thanks for doing the research for the Issue. By the way, the gestures were working in your environment when you created this Pull Request, correct? |
I test it on Android And Windows with Mouse,the pinch gesture in the Windows was not tested at the time,because I only had mouse mode at the time. I think input in the UI test framework can be responded to correctly and the correct test passes, which means that the code is correct on the target platform of the test. The remaining problem is that the framework cannot emit correct touch events, which should not be Obstacles to supporting target platforms. At the same time, the project also provides a double-click zoom gesture, which can be supported on the desktop. So I think we can make it clear in the support section on which platforms certain gestures are not available and why. In addition, I think we can consider supporting the scroll wheel to adjust the zoom ratio in zoom mode, and hold down the ctrl key and scroll wheel to open zoom when the focus is on the zoom control, which helps better support mouse users. |
I agree with you. Again, I am new to KMP, so I am reviewing your pull request as I learn. It will take some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sanlorng
Sorry it took so long.
I added some comments.
zoomable/src/commonTest/kotlin/net/engawapg/lib/zoomable/ZoomStateTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sanlorng
Thank you for your quick response.
I added one more question.
Could you confirm?
Move project to kotlin multiplatform library
zoomable
to common codesample
to common code and platform spec sample(accompanist
)test
to commonAdd desktop support
Testing
Desktop
![image](https://private-user-images.githubusercontent.com/26089739/326015768-e0a1ef4f-ceb1-4222-a0e5-8268563ca579.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1NTk5MjQsIm5iZiI6MTcyNDU1OTYyNCwicGF0aCI6Ii8yNjA4OTczOS8zMjYwMTU3NjgtZTBhMWVmNGYtY2ViMS00MjIyLWEwZTUtODI2ODU2M2NhNTc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI1VDA0MjAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM0NjY0MzY5OWQzYTM3ZGNlY2Y2NjRhNzBjMzVkOWE4MjUyMzVhZTU2NDg5NGIzNzlkZjcxMWMwZTlkYTBkNGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5UqHas40or6kA1D7qOMaf-cjn6e0IZwhkKY7iyOkiOQ)
Android(Robolectric)
![image](https://private-user-images.githubusercontent.com/26089739/326016335-10b4259e-8bdf-4b66-9257-243c3952d8c9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1NTk5MjQsIm5iZiI6MTcyNDU1OTYyNCwicGF0aCI6Ii8yNjA4OTczOS8zMjYwMTYzMzUtMTBiNDI1OWUtOGJkZi00YjY2LTkyNTctMjQzYzM5NTJkOGM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI1VDA0MjAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY5MDdhZjFiMTFhZDU4YWYzYjNhMDgzMmI4MzgwZjZkMDYwYzdhMGY0NTU3ODVhOGRiNWUwYWJlMzA3MzRlMGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.uXLdHAltIw6ydQ1WDXMqGeFx_sS0PHqOuzxdL5LeGuk)