Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Compile - Dependencies: Use node LTS 20 #74

Closed
wants to merge 1 commit into from
Closed

USWDS-Compile - Dependencies: Use node LTS 20 #74

wants to merge 1 commit into from

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Oct 13, 2023 •
edited
Loading

Summary

Updating to node LTS 20 & NPM dependencies.

Related issue

Closes #71. Related to uswds/uswds#5010.

Problem statement

Updating to stay up-to-date with latest Node LTS and dependencies. As well as avoiding compatibility issues with CloudGov pages once node 16 is deprecated.

Testing and review

  1. Go to Sandbox branch test-uswds-compile-78-node-update.
  2. Run npm install.
  3. Run tasks listed in gulpfile.js.
  4. All tasks should work as expected.

@mejiaj mejiaj marked this pull request as ready for review October 13, 2023 19:12
@mejiaj mejiaj added Affects: Build Relates to the build process Affects: Compiling Related to compiling Sass or JavaScript Affects: Dependencies Relates to project dependencies Context: JavaScript Issue is in JavaScript Role: Dev Development/engineering skills needed labels Oct 13, 2023
@mejiaj mejiaj self-assigned this Oct 13, 2023
@mejiaj mejiaj added this to the compile 1.2.0 milestone Nov 8, 2023
@mejiaj mejiaj changed the title USWDS-Compile - Dependencies: Use node LTS 18 USWDS-Compile - Dependencies: Use node LTS 20 Nov 13, 2023
@mejiaj
Copy link
Contributor Author

mejiaj commented Nov 13, 2023 •
edited
Loading

Closing in favor of updated branch. #71.

@mejiaj mejiaj closed this Nov 13, 2023
@mejiaj mejiaj deleted the jm-feature-node-18-update branch November 13, 2023 17:42
@mejiaj mejiaj removed this from the compile 1.1.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano Awaiting requested review from thisisdano

Assignees

@mejiaj mejiaj

Labels
Adding During Sprint Affects: Build Relates to the build process Affects: Compiling Related to compiling Sass or JavaScript Affects: Dependencies Relates to project dependencies Context: JavaScript Issue is in JavaScript Role: Dev Development/engineering skills needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USWDS-Compile - Feature: Update USWDS version & other deps
1 participant
@mejiaj