USWDS-Compile - Dependencies: Use Node LTS 20 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisdano
reviewed
Nov 14, 2023
| @@ -0,0 +1 @@ | |||
| nodejs 20.9.0 | |||
There was a problem hiding this comment.
Added a .tool-versions file for folks who use other version managers like asdf
amyleadem
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Looks good to me. Here is what I tested:
- Successfully ran the
uswds-sandboxtests described in the PR description:- Ran
npm install,npm run uswds:copyAssets,npm run watchwithout error - Confirmed that styles render as expected
- Ran
- Checked that references to previous node versions in docs have been updated to v20
- Confirmed README formatting hasn’t changed
mahoneycm
approved these changes
Nov 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest Node LTS 20 and update dependencies. Using latest LTS version of node and updated version of USWDS and SASS. Closes #71.
Dependencies
How to test
test-uswds-compile-78-node-updatebranch.npm install.npm run uswds:copyAssetsnpm run watch