-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Sandbox: Zebra prototype #126
base: main
Are you sure you want to change the base?
Conversation
@jaclinec I've made the following updates to the prototype:
Please let me know if you need any more changes! Happy to jump on a call if that is easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looking great! A couple very minor changes I thought we might be able to implement but functionally it's looking solid 👍
<fieldset class="usa-fieldset"> | ||
<legend class="usa-legend"> | ||
I certify that I read, understand, and agree to the Purplestone National Park's <a | ||
href="http://designsystem.digital.gov">rules of conduct and environmental stewardship</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(OPTIONAL) Remove design system href
Should we swap design systemhref to hash symbol or javascript:void{0}; in case tester click?
The hash will reload the same page while the javascript:void(0)
will simply prevent the click from doing anything. Both should maintain the users selections.
href="http://designsystem.digital.gov">rules of conduct and environmental stewardship</a>. | |
href="#">rules of conduct and environmental stewardship</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was confusion when the href was empty because it looked like it was broken. I put a dummy link in there to at least give the expected behavior. @jaclinec is there a better url to use here?
Update 03/11/24Updated the 2nd prototype to specify that the Month input should have a numerical pattern to match the other inputs. I also updated the memorable date hint to read:
|
Co-authored-by: mahoneycm <charlie.mahoney@bixal.com>
Co-authored-by: mahoneycm <charlie.mahoney@bixal.com>
Co-authored-by: mahoneycm <charlie.mahoney@bixal.com>
Co-authored-by: mahoneycm <charlie.mahoney@bixal.com>
Follow up workNote I have opened #130 to evaluate how we can make these partials re-usable for future prototyping. I've added the "Needs: Discussion" label so that we can talk through possible approaches. |
Is this work meant to be merged? |
Summary
Created a prototype for "Zebra" batch user testing.
The prototype includes the components outlined on this Mural board.
Related issue
Closes #125
Preview link