Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Migration guide - convert accordion to markdown #1543

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Apr 21, 2022

Preview link

3.0 Migration page

Description

Convert accordions to markdown and standardize formatting for new/old code samples.

Tasks completed:

  • Make accordion content easier to understand/edit
    • Convert accordions to use as much markdown as possible
    • Add comments to clarify accordion sections
  • Standardize text for code changes to be "Old code"/"New code"
    • ⚠️ Inconsistent styling/tags - Had difficulty preserving <h6> styles on items inside an ordered list.
  • Standardize presentation of code blocks to use .site-terminal styles

@amyleadem amyleadem marked this pull request as ready for review April 22, 2022 13:45
Comment on lines +246 to +250
1. Check this list to see if you changed the default value.
1. If you did change the default value, this change will no longer affect the input tile.
1. Assure that the input tile still displays well: check your codebase for instances of `input--tile`.
1. Check the affected part of your site if you get a match.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go ahead and increase each list item in the markdown for added readability? (1, 2, 3, 4... vs 1, 1, 1, 1)

@mahoneycm mahoneycm merged commit 298fa0e into cm-migrate-3.0 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants