Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snyk protect from develop #1555

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Apr 26, 2022

Description

Removes snyk protect from package.json. Updates to Snyk have caused this warning to popup:

⚠ WARNING: Snyk protect was removed at 31 March 2022.
Please use '@snyk/protect' package instead: https://updates.snyk.io/snyk-wizard-and-snyk-protect-removal-224137 

Work was done in snyk and github settings to get the same functionality using the new standard.

Additional information

The snyk wizard command is also deprecated and we'll now need to use snyk ignore. See documentation here →

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@mejiaj mejiaj requested a review from thisisdano April 26, 2022 19:19
@mejiaj mejiaj marked this pull request as ready for review April 26, 2022 19:19
@thisisdano thisisdano merged commit b0c9ba4 into develop Apr 27, 2022
@thisisdano thisisdano deleted the jm-develop-remove-snyk-protect branch April 27, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants