Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

古いgenerate tlm コマンドを新しいものに置換する #182

Merged
merged 2 commits into from
Aug 15, 2023
Merged

古いgenerate tlm コマンドを新しいものに置換する #182

merged 2 commits into from
Aug 15, 2023

Conversation

chutaro
Copy link
Contributor

@chutaro chutaro commented Aug 15, 2023 •
edited by seki-hiro
Loading

Issue

詳細

以下二つに残っていたので置換した

  • nbc_start_hk
  • コマンドファイル

検証結果

ビルドチェック (どちらもチェック)

  • SILSでのビルドチェックに通った(CIで確認)
  • vMicroでのビルドチェックに通った

動作確認チェック (いずれかをチェック)

  • SILSでアルゴリズムが想定通りに動いた
  • 実機でアルゴリズムが想定通りに動いた
  • (テレコマ試験の場合)コマンドファイルを使った試験をパスした

試験結果詳細記述場所 or 詳細ログ保存場所へのリンク

  • 図や表で記述する

補足

NA

@chutaro chutaro added the ✈️ priority::medium priority medium label Aug 15, 2023
@chutaro chutaro requested review from sksat and a team as code owners August 15, 2023 01:06
@chutaro chutaro self-assigned this Aug 15, 2023
@chutaro chutaro requested review from 200km, seki-hiro, suzuki-toshihir0 and conjikidow and removed request for a team and sksat August 15, 2023 01:06
@200km 200km added the 🐬 minor update Minor update label Aug 15, 2023
200km
200km approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基本は問題ないと思うのでapproveします。
@seki-hiro 念の為、vMicroビルトと修正されたopsファイルでGnerate_TLMやってみてもらえると嬉しいです。

seki-hiro
seki-hiro approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@seki-hiro seki-hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nbc書き換え部分のHK3種が降りてくること、書き換え後のopsファイルのコマンドでテレメが降りてくること、vMicroがbuildできることを確認しました。

@seki-hiro
Copy link
Member

@chutaro マージお願いします！

@seki-hiro seki-hiro mentioned this pull request Aug 15, 2023
Open
@chutaro chutaro merged commit 3ed5cc1 into develop Aug 15, 2023
11 of 14 checks passed
@chutaro chutaro deleted the feature/replace_old_generate_tlm branch August 15, 2023 15:51
@200km 200km added this to the 開発仮目標1 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seki-hiro seki-hiro seki-hiro approved these changes

@200km 200km 200km approved these changes

@suzuki-toshihir0 suzuki-toshihir0 Awaiting requested review from suzuki-toshihir0 suzuki-toshihir0 is a code owner automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow is a code owner automatically assigned from ut-issl/aocs

Assignees

@chutaro chutaro

Labels
✈️ priority::medium priority medium 🐬 minor update Minor update
Projects
None yet
Milestone
開発仮目標1
Development

Successfully merging this pull request may close these issues.
3 participants
@chutaro @seki-hiro @200km