Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre Release (v3.6.0-beta.0): TLM生成関数の返り値を int から TF_ACK にするなど #288

Merged
merged 11 commits into from
Mar 12, 2022
Merged

Pre Release (v3.6.0-beta.0): TLM生成関数の返り値を int から TF_ACK にするなど #288

merged 11 commits into from
Mar 12, 2022

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Mar 8, 2022 •
edited
Loading

概要

TLM生成関数の返り値を int から TF_ACK にするなど

Issue

詳細

  • tlm funcの返り値修正とそれに伴うロジック整理
  • tlmのcopy関数を，memcpyで高速化
  • コマンド引数取得方法を最新の方法に
  • テストの追加

検証結果

すべてのテストが通ればOK

影響範囲

マージ前のToDo

  • バージョン上げ

その他

@meltingrabbit meltingrabbit requested review from chutaro and yngyu March 8, 2022 17:22
@meltingrabbit meltingrabbit self-assigned this Mar 8, 2022
@meltingrabbit meltingrabbit mentioned this pull request Mar 8, 2022
Merged
@meltingrabbit meltingrabbit changed the title Pre Release (v3.6.0-beta.0): TLM生成関数の返り値を int から TF_ACK にするなど WIP: Pre Release (v3.6.0-beta.0): TLM生成関数の返り値を int から TF_ACK にするなど Mar 8, 2022
@meltingrabbit meltingrabbit mentioned this pull request Mar 8, 2022
Merged
@meltingrabbit meltingrabbit force-pushed the feature/fix_TF_ACK branch 2 times, most recently from 6fa991a to 2ab8c03 Compare March 9, 2022 05:28
@meltingrabbit meltingrabbit changed the title WIP: Pre Release (v3.6.0-beta.0): TLM生成関数の返り値を int から TF_ACK にするなど Pre Release (v3.6.0-beta.0): TLM生成関数の返り値を int から TF_ACK にするなど Mar 9, 2022
@meltingrabbit
Copy link
Collaborator Author

@yngyu wip外したのでお願いします．

@meltingrabbit meltingrabbit merged commit 365e461 into develop Mar 12, 2022
@meltingrabbit meltingrabbit deleted the feature/fix_TF_ACK branch March 12, 2022 09:27
@meltingrabbit
Copy link
Collaborator Author

releaseうちました

https://github.com/ut-issl/c2a-core/releases/tag/v3.6.0-beta.0

@meltingrabbit meltingrabbit mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yngyu yngyu yngyu approved these changes

@chutaro chutaro Awaiting requested review from chutaro

Assignees

@meltingrabbit meltingrabbit

Labels
priority::medium priority medium tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @yngyu