Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

単一OBCの場合でも,TLM IDとして使える定義域をチェックするように #13

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

meltingrabbit
Copy link
Collaborator

概要

単一OBCの場合でも,TLM IDとして使える定義域をチェックするように

Issue

NA

詳細

TLM IDのバリデーションを追加した

検証結果

C2A Coreや2nd OBCのあるISSL MOBC環境で試した.

Copy link
Contributor

@yngyu yngyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK です。

Copy link
Contributor

@yngyu yngyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これとは関係無いですが、tlm-cmd-code-generator って formatter と linter あるんでしたっけ?

@sksat
Copy link
Collaborator

sksat commented Jan 19, 2022

なさそう > formatter,linter

@yngyu
Copy link
Contributor

yngyu commented Jan 19, 2022

core に追加されたやつをコピペして貼ろうとしたらpush 権限が無いって言われてしまったので別PRで追加お願いできますか?

@meltingrabbit
Copy link
Collaborator Author

フォーマッター,リンターは

ut-issl/c2a-core#89

でやってるので,coreマージされたし,すぐ入れるので,待ってて~(今でてるPRの後がいいなと思ってました).

@meltingrabbit
Copy link
Collaborator Author

meltingrabbit commented Jan 19, 2022

権限はあとでwrite権限足しておきます!

@meltingrabbit meltingrabbit merged commit cd0f519 into main Jan 19, 2022
@meltingrabbit meltingrabbit deleted the feature/check_db_range_for_single_obc branch January 19, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants