Cmd DB に "Cmd_" がない DB への対応 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
enhancement
1 task
2 tasks
meltingrabbit
changed the title
KOBA789
reviewed
Apr 4, 2023
README.md
Outdated
| @@ -33,6 +33,8 @@ $ python GenerateC2ACode.py | |||
| "db_prefix" : "SAMPLE_MOBC", | |||
| # TLM ID の定義域 | |||
| "tlm_id_range" : ["0x00", "0x100"], | |||
| # Cmd DB の Name に "Cmd_" の接頭辞が含まれるか？（今後は含まれないのが基本とする） | |||
| "is_cmd_prefix_in_db" : 0, | |||
There was a problem hiding this comment.
is_cmd_prefixed_in_db あるいは does_cmd_have_prefix_in_db が正しそう。
長いので前者かな
There was a problem hiding this comment.
あとこれ true/false じゃなくていいんですか？（慣習的に 0/1 ？）
There was a problem hiding this comment.
了解．直します．
true/false はどっかでまとめて直したい（一部だけやると混乱するので．．．）
chutaro
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Cmd DB に "Cmd_" がない DB への対応
Issue
詳細
以下とともにマージする
検証結果
影響範囲