Fix relative c2a-core header include #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sksat v1.7.0 がすでに出てるので，rebase して欲しいです |
|
OK．rebase します． |
|
あれ |
|
あーーー，後から outside collabolator になった & origin 間違えた．やり直し． |
sksat
force-pushed
the
feature/fix-relative-core-include
branch
from
24729f3 to
b1756b6
Compare
2 tasks
meltingrabbit
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
相対パスで c2a-core のヘッダを include しているのをやめる
Issue
src_coreをなんとかしたい c2a-core#6 (comment)詳細
現在の C2A での標準的な include の仕方に則り，
#include "../../src_core/hoge.h"をやめ，#include <src_core/hoge.h>のようにする以下とともにマージする
検証結果
影響範囲