Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #59 - always determine executable tests via annotation API before executing tests #61

Merged
merged 2 commits into from
Apr 28, 2019
Merged

FIX #59 - always determine executable tests via annotation API before executing tests #61

merged 2 commits into from
Apr 28, 2019

Conversation

PhilippSalvisberg
Copy link
Member

Pro:

  • ensures that non-tests procedures are executed

Cons:

  • leads to a delay before starting a test (delay is small, even on large schemas)
  • delay might be huge for large schemas and empty annotation cache (corner case)

@PhilippSalvisberg
fixes #59 - always use annotation API
f019a4e 
to determine executable utPLSQL test units before executing a test
@PhilippSalvisberg
change to snapshot version 0.7.2-SNAPSHOT
6a89971
@PhilippSalvisberg PhilippSalvisberg merged commit f410bd0 into utPLSQL:master Apr 28, 2019
@jgebal
Copy link
Member

jgebal commented Apr 28, 2019

The delay issue will get addressed for huge schemas (like EBS) with optional DDL trigger in utPLSQL install (PR is still in progress - needs more testing and documentation update).
utPLSQL/utPLSQL#901
See also: utPLSQL/utPLSQL#631

@PhilippSalvisberg PhilippSalvisberg deleted the issue_59 branch July 4, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippSalvisberg @jgebal