Fix issue #109

The temporary return value of method wxString::utf8_str(), representing the cipher name, was destroyed, before it could be used to configure the cipher scheme. The value is now assigned to a local variable, first.
utelle · Mar 1, 2023 · dab59b8 · dab59b8
1 parent 4f2be04
commit dab59b8
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/wxsqlite3.cpp b/src/wxsqlite3.cpp
@@ -5725,7 +5725,8 @@ wxSQLite3Cipher::GetCipherType(const wxString& cipherName)
 bool
 wxSQLite3Cipher::SetCipher(wxSQLite3Database& db, wxSQLite3CipherType cipherType)
 {
-  const char* cipherName = GetCipherName(cipherType).utf8_str();
+  wxCharBuffer strCipherName = GetCipherName(cipherType).utf8_str();
+  const char* cipherName = strCipherName;
   sqlite3* dbHandle = (sqlite3*) GetDatabaseHandle(db);
   int newCipherType = (dbHandle != NULL) ? sqlite3mc_config(dbHandle, "cipher", sqlite3mc_cipher_index(cipherName)) : WXSQLITE_CIPHER_UNKNOWN;
   return (newCipherType > 0 && newCipherType == (int) cipherType && newCipherType != WXSQLITE_CIPHER_UNKNOWN);
@@ -5734,7 +5735,8 @@ wxSQLite3Cipher::SetCipher(wxSQLite3Database& db, wxSQLite3CipherType cipherType
 bool
 wxSQLite3Cipher::SetCipherDefault(wxSQLite3Database& db, wxSQLite3CipherType cipherType)
 {
-  const char* cipherName = GetCipherName(cipherType).utf8_str();
+  wxCharBuffer strCipherName = GetCipherName(cipherType).utf8_str();
+  const char* cipherName = strCipherName;
   sqlite3* dbHandle = (sqlite3*) GetDatabaseHandle(db);
   int newCipherType = (dbHandle != NULL) ? sqlite3mc_config(dbHandle, "default:cipher", sqlite3mc_cipher_index(cipherName)) : WXSQLITE_CIPHER_UNKNOWN;
   return (newCipherType > 0 && newCipherType == (int) cipherType && newCipherType != WXSQLITE_CIPHER_UNKNOWN);