Add hipBLAS feature and fix build script #337
Conversation
So to be clear, if I merge this, it still segfaults with HIP, just later? |
Correct, previously it would not build at all; now it builds, links, and can run some things, but will quickly segfault on the GPU when attempting to do anything of consequence. I've been unable to pinpoint why so hopefully somebody more knowledgeable can use this as a head start. |
|
Do you befit from having this merged, or is it fine here as a starting point for someone who wants to bring it across the finish line? I'd prefer to not give the impression of HIP support if it's known to not work, but if it's useful then I don't mind merging. |
|
I'm fine with leaving keeping a local dependency for now since I'm not able to get my workload running. I'll mark this as a draft |
AdamNiederer
force-pushed
the
enable-hipblas
branch
from
cf06956 to
9cbc774
Compare
Attempts to copy the CMake build steps as much as possible. GPU is detected when running but on my setup appears to segfault when loading the model. I'm at a bit of a loss on the segfault but this is definitely better than before.
AdamNiederer
force-pushed
the
enable-hipblas
branch
from
9cbc774 to
cd98222
Compare
Attempts to copy the CMake build steps as much as possible. GPU is detected and models are loaded into VRAM but it appears to segfault when doing anything else. I'm at a bit of a loss on the segfault but this is definitely better than before.