Added IANA TimeZone-type. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilssonemma
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Renamed the former type `TimeZone` to `TimeZoneOffset`. (This should not be breaking, since it is not exported in `index.ts` and only internal type.) * Change to existing code is the `TimeZone`-parameter for DateTime.localize which took what before was a `TimeZoneOffset`. However, this wasn't working. In reality it expected a IANA-timezone. (Else an error was thrown.) * Added a `TimeZone` type for IANA-timezone identifiers. (Not strictly ISO-standard, but related to ISO 8601) IANA-Timezone looks like this: * `"Europe/Stockholm"` * `"Europe/London"` * `"UTC"`
nilssonemma
added a commit
that referenced
this pull request
Jul 6, 2023
* fix date validation. (#96) * Precision format (#98) * Added TimeZone and Precision. * Add formats to localize , add truncate, rework is * Updated lock-file Co-authored-by: Amanda Hwatz Björkholm <amanda.hwatz@paxport.net> * FIxed typo and clearified weekday output (#99) * Datetime (#100) * Added Date.span. * Added Date.span * Modify datetime localize and change format. * Change test to equal in DateTime test. Co-authored-by: Benjamin Josefsson <benjamin.josefsson@paxport.net> Co-authored-by: Amanda Hwatz Björkholm <amanda.hwatz@paxport.net> * TimeSpan.toX() now works. (#102) * Solve date bug with daylight saving time (#101) * Is undefined (#103) * Fixed is check! * Added tests to test undefined. * Add next weekday function (#104) * Added invert function. (#105) Co-authored-by: Anton Kroner <anton.korner@paxport.net> * Add DateRange.toDates function (#106) * Add date range to dates function * Remove vulnerabilities * Added isoly export, updated tests to use it. (#108) * Added isoly export, updated tests to use it. * Fixed vulnerably build dependencies. * Replace NNBSP with space. (#109) * Added IANA TimeZone-type. (#110) * Renamed the former type `TimeZone` to `TimeZoneOffset`. (This should not be breaking, since it is not exported in `index.ts` and only internal type.) * Change to existing code is the `TimeZone`-parameter for DateTime.localize which took what before was a `TimeZoneOffset`. However, this wasn't working. In reality it expected a IANA-timezone. (Else an error was thrown.) * Added a `TimeZone` type for IANA-timezone identifiers. (Not strictly ISO-standard, but related to ISO 8601) IANA-Timezone looks like this: * `"Europe/Stockholm"` * `"Europe/London"` * `"UTC"` * Add Kosovo, and refactor CountryCode (#111) * Add Kosovo, and refactor CountryCode * Remove console log. * DateTime.span (#112) * DateTime.span added parameter "greatestUnit" * ci: version bump to release-2.0.19 * Introducing the fromLocalDateTime Function for Timezone Offset Handling (#113) Datetime.fromLocalDateTime * ci: version bump to release-2.0.20 * implemented firstOfYear (#114) * implemented firstOfYear * implemented lastOfYear * 0 vulnerabilities * ci: version bump to release-2.0.21 * fix: fixed bug with currency round (#115) * fix: fixed bug with currency round * fix: audit fix * ci: version bump to release-2.0.22 --------- Co-authored-by: qijieye <86956109+qijieye@users.noreply.github.com> Co-authored-by: Amanda Hwatz Björkholm <amandahwatz@gmail.com> Co-authored-by: Amanda Hwatz Björkholm <amanda.hwatz@paxport.net> Co-authored-by: Magnus Gustafsson <magnus@intergiro.com> Co-authored-by: Benjamin Josefsson <92915807+benjaminjosefsson@users.noreply.github.com> Co-authored-by: Benjamin Josefsson <benjamin.josefsson@paxport.net> Co-authored-by: marcushanses <79835961+marcushanses@users.noreply.github.com> Co-authored-by: AntonCroner <113976225+AntonCroner@users.noreply.github.com> Co-authored-by: Anton Kroner <anton.korner@paxport.net> Co-authored-by: Simon Mika <simonmika@users.noreply.github.com> Co-authored-by: Lasse Löfquist <tvartom@users.noreply.github.com> Co-authored-by: Automated Version Bump <gh-action-bump-version@users.noreply.github.com> Co-authored-by: Elias Eriksson <elias@issuefab.com>
nilssonemma
added a commit
that referenced
this pull request
Jul 6, 2023
* fix date validation. (#96) * Precision format (#98) * Added TimeZone and Precision. * Add formats to localize , add truncate, rework is * Updated lock-file Co-authored-by: Amanda Hwatz Björkholm <amanda.hwatz@paxport.net> * FIxed typo and clearified weekday output (#99) * Datetime (#100) * Added Date.span. * Added Date.span * Modify datetime localize and change format. * Change test to equal in DateTime test. Co-authored-by: Benjamin Josefsson <benjamin.josefsson@paxport.net> Co-authored-by: Amanda Hwatz Björkholm <amanda.hwatz@paxport.net> * TimeSpan.toX() now works. (#102) * Solve date bug with daylight saving time (#101) * Is undefined (#103) * Fixed is check! * Added tests to test undefined. * Add next weekday function (#104) * Added invert function. (#105) Co-authored-by: Anton Kroner <anton.korner@paxport.net> * Add DateRange.toDates function (#106) * Add date range to dates function * Remove vulnerabilities * Added isoly export, updated tests to use it. (#108) * Added isoly export, updated tests to use it. * Fixed vulnerably build dependencies. * Replace NNBSP with space. (#109) * Added IANA TimeZone-type. (#110) * Renamed the former type `TimeZone` to `TimeZoneOffset`. (This should not be breaking, since it is not exported in `index.ts` and only internal type.) * Change to existing code is the `TimeZone`-parameter for DateTime.localize which took what before was a `TimeZoneOffset`. However, this wasn't working. In reality it expected a IANA-timezone. (Else an error was thrown.) * Added a `TimeZone` type for IANA-timezone identifiers. (Not strictly ISO-standard, but related to ISO 8601) IANA-Timezone looks like this: * `"Europe/Stockholm"` * `"Europe/London"` * `"UTC"` * Add Kosovo, and refactor CountryCode (#111) * Add Kosovo, and refactor CountryCode * Remove console log. * DateTime.span (#112) * DateTime.span added parameter "greatestUnit" * ci: version bump to release-2.0.19 * Introducing the fromLocalDateTime Function for Timezone Offset Handling (#113) Datetime.fromLocalDateTime * ci: version bump to release-2.0.20 * implemented firstOfYear (#114) * implemented firstOfYear * implemented lastOfYear * 0 vulnerabilities * ci: version bump to release-2.0.21 * fix: fixed bug with currency round (#115) * fix: fixed bug with currency round * fix: audit fix * ci: version bump to release-2.0.22 --------- Co-authored-by: qijieye <86956109+qijieye@users.noreply.github.com> Co-authored-by: Amanda Hwatz Björkholm <amandahwatz@gmail.com> Co-authored-by: Amanda Hwatz Björkholm <amanda.hwatz@paxport.net> Co-authored-by: Magnus Gustafsson <magnus@intergiro.com> Co-authored-by: Benjamin Josefsson <92915807+benjaminjosefsson@users.noreply.github.com> Co-authored-by: Benjamin Josefsson <benjamin.josefsson@paxport.net> Co-authored-by: marcushanses <79835961+marcushanses@users.noreply.github.com> Co-authored-by: AntonCroner <113976225+AntonCroner@users.noreply.github.com> Co-authored-by: Anton Kroner <anton.korner@paxport.net> Co-authored-by: Simon Mika <simonmika@users.noreply.github.com> Co-authored-by: Lasse Löfquist <tvartom@users.noreply.github.com> Co-authored-by: Automated Version Bump <gh-action-bump-version@users.noreply.github.com> Co-authored-by: Elias Eriksson <elias@issuefab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the former type
TimeZonetoTimeZoneOffset. (This should not be breaking, since it is not exported inindex.tsand only internal type.)Change to existing code is the
TimeZone-parameter for DateTime.localize which took what before was aTimeZoneOffset. However, this wasn't working. In reality it expected a IANA-timezone. (Else an error was thrown.)Added a
TimeZonetype for IANA-timezone identifiers. (Not strictly ISO-standard, but related to ISO 8601)IANA-Timezone looks like this:
"Europe/Stockholm""Europe/London""UTC"