chore: update code based on comments

utkarsha-deriv · May 2, 2024 · 6cdfaf5 · 6cdfaf5
1 parent 1331686
commit 6cdfaf5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/account/src/Sections/Profile/PersonalDetails/personal-details-form.tsx b/packages/account/src/Sections/Profile/PersonalDetails/personal-details-form.tsx
@@ -398,7 +398,7 @@ export const PersonalDetailsForm = observer(({ history }: { history: BrowserHist
                                             id={'phone'}
                                             label={localize('Phone number*')}
                                             className={
-                                                account_settings.phone_number_verification.verified
+                                                account_settings?.phone_number_verification?.verified
                                                     ? 'account-form__fieldset--phone'
                                                     : ''
                                             }
@@ -410,7 +410,7 @@ export const PersonalDetailsForm = observer(({ history }: { history: BrowserHist
                                             error={errors.phone}
                                             disabled={
                                                 isFieldDisabled('phone') ||
-                                                account_settings.phone_number_verification.verified
+                                                account_settings?.phone_number_verification?.verified
                                             }
                                             data-testid='dt_phone'
                                         />

diff --git a/packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx b/packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx
@@ -13,7 +13,7 @@ export const VerifyButton = observer(() => {
     const { is_mobile } = ui;
     const { account_settings } = client;
     const { phone_number_verification } = account_settings;
-    const { verified } = phone_number_verification;
+    const { verified: phone_number_verified } = phone_number_verification;
     const history = useHistory();
 
     const redirectToPhoneVerification = () => {
@@ -22,7 +22,7 @@ export const VerifyButton = observer(() => {
 
     return (
         <div className='account-form__phone-verification-btn'>
-            {verified ? (
+            {phone_number_verified ? (
                 <div className='account-form__phone-verification-btn--verified'>
                     <LegacyWonIcon iconSize='xs' />
                     <CaptionText bold color='#4bb4b3'>

diff --git a/packages/account/src/Styles/account.scss b/packages/account/src/Styles/account.scss
@@ -448,10 +448,10 @@ $MIN_HEIGHT_FLOATING: calc(
 
                 .phone-verification__popover {
                     position: absolute;
-                    right: -3rem;
+                    inset-inline-end: -3rem;
 
                     @include mobile {
-                        right: 0rem;
+                        inset-inline-end: 0rem;
                     }
                 }
             }