Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is nightly still required? #18

Closed
thedodd opened this issue Dec 26, 2018 · 4 comments · Fixed by #19
Closed

Is nightly still required? #18

thedodd opened this issue Dec 26, 2018 · 4 comments · Fixed by #19

Comments

@thedodd
Copy link

thedodd commented Dec 26, 2018

After reviewing #8 (about 5 months old), looks like this crate was cut over to proc-macro system. As proc-macro has recently stabilized, I figured I would ask.

@palfrey
Copy link
Contributor

palfrey commented Dec 30, 2018

Sadly, it's still required. Features this library seems to need (gotten by deleting the #![feature] block from lib.rs and compiling on stable) are as follows:

@palfrey
Copy link
Contributor

palfrey commented Dec 30, 2018

Although the rustc_private features could probably be replaced with unicode_xid

@palfrey
Copy link
Contributor

palfrey commented Jan 11, 2019

So, this got mostly fixed by #19 but the README still refers to nightly being needed.

@utkarshkukreti
Copy link
Owner

@palfrey, thanks for pointing that out. I've removed the nightly note!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants