config(qemu): re-introduce blinking cursor option

Resolves #4296

Configuration/UTMConfigurationTerminal.swift

@@ -36,6 +36,9 @@ struct UTMConfigurationTerminal: Codable, Identifiable {
     /// Command to send when the console is resized.
     var resizeCommand: String?
 
+    /// Terminal has a blinking cursor.
+    var hasCursorBlink: Bool = true
+
     let id = UUID()
 
     enum CodingKeys: String, CodingKey {
@@ -45,6 +48,7 @@ struct UTMConfigurationTerminal: Codable, Identifiable {
         case font = "Font"
         case fontSize = "FontSize"
         case resizeCommand = "ResizeCommand"
+        case hasCursorBlink = "CursorBlink"
     }
 
     init() {
@@ -58,6 +62,7 @@ struct UTMConfigurationTerminal: Codable, Identifiable {
         font = try values.decode(QEMUTerminalFont.self, forKey: .font)
         fontSize = try values.decode(Int.self, forKey: .fontSize)
         resizeCommand = try values.decodeIfPresent(String.self, forKey: .resizeCommand)
+        hasCursorBlink = try values.decodeIfPresent(Bool.self, forKey: .hasCursorBlink) ?? true
     }
 
     func encode(to encoder: Encoder) throws {
@@ -71,6 +76,7 @@ struct UTMConfigurationTerminal: Codable, Identifiable {
         try container.encode(font, forKey: .font)
         try container.encode(fontSize, forKey: .fontSize)
         try container.encodeIfPresent(resizeCommand, forKey: .resizeCommand)
+        try container.encode(hasCursorBlink, forKey: .hasCursorBlink)
     }
 }
 
@@ -88,6 +94,7 @@ extension UTMConfigurationTerminal {
             fontSize = fontSizeNum.intValue
         }
         resizeCommand = oldConfig.consoleResizeCommand
+        hasCursorBlink = oldConfig.consoleCursorBlink
     }
 
     #if os(macOS)
@@ -102,6 +109,7 @@ extension UTMConfigurationTerminal {
             fontSize = fontSizeNum.intValue
         }
         resizeCommand = oldConfig.consoleResizeCommand
+        hasCursorBlink = oldConfig.consoleCursorBlink
     }
     #endif
 }

Platform/Shared/VMConfigDisplayConsoleView.swift

@@ -58,6 +58,7 @@ struct VMConfigDisplayConsoleView: View {
                     .frame(width: 50)
                     .multilineTextAlignment(.trailing)
             }
+            Toggle("Blinking cursor?", isOn: $config.hasCursorBlink)
         }
 
         DetailedSection("Resize Console Command", description: "Command to send when resizing the console. Placeholder $COLS is the number of columns and $ROWS is the number of rows.") {

Platform/iOS/Display/VMDisplayTerminalViewController.swift

@@ -156,6 +156,7 @@ extension VMDisplayTerminalViewController {
             terminalView.nativeForegroundColor = UIColor(textColor)
             terminalView.nativeBackgroundColor = UIColor(backgroundColor)
         }
+        terminalView.getTerminal().setCursorStyle(style.hasCursorBlink ? .blinkBlock : .steadyBlock)
     }
 }
 

Platform/iOS/VMDisplayHostedView.swift

@@ -146,8 +146,9 @@ struct VMDisplayHostedView: UIViewControllerRepresentable {
             mvc.delegate = context.coordinator
             mvc.setDisplayScaling(state.displayScale, origin: state.displayOrigin)
             vc = mvc
-        case .serial(let serial, _):
-            vc = VMDisplayTerminalViewController(port: serial)
+        case .serial(let serial, let id):
+            let style = vm.qemuConfig.serials[id].terminal
+            vc = VMDisplayTerminalViewController(port: serial, style: style)
             vc.delegate = context.coordinator
         }
         context.coordinator.vmStateCancellable = session.$vmState.sink { vmState in

Platform/macOS/Display/VMDisplayTerminal.swift

@@ -49,6 +49,7 @@ extension VMDisplayTerminal {
             terminalView.nativeBackgroundColor = NSColor(backgroundColor)
         }
         terminalView.getTerminal().resize(cols: windowConfig.columns, rows: windowConfig.rows)
+        terminalView.getTerminal().setCursorStyle(config.hasCursorBlink ? .blinkBlock : .steadyBlock)
         let size = window.frameRect(forContentRect: terminalView.getOptimalFrameSize()).size
         let frame = CGRect(origin: window.frame.origin, size: size)
         window.minSize = size