-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/Update zh-Hant localization #5652
Conversation
@pan93412 can you comment on these changes? |
@@ -1491,7 +1491,7 @@ | |||
"Share" = "分享"; | |||
|
|||
/* No comment provided by engineer. */ | |||
"Share a copy of this VM and all its data." = "分享虛擬機和其所有資料的拷貝。"; | |||
"Share a copy of this VM and all its data." = "分享虛擬機和其所有資料的複製。"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it for all 複製
translation? I noticed that there are many places using "複製" in current translation, and the source strings are clone
, duplicate
and copy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apple uses "複製" as their translation of duplicate:
<TextItem>
<Description> ^1 is the name of the file</Description>
<Position>DU6_V1</Position>
<TranslationSet>
<base loc="en">Preparing to duplicate “^1”</base>
<tran loc="zh-TW">正在準備複製「^1」</tran>
</TranslationSet>
</TextItem>
I have not found the translation Apple uses for "clone."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platform/zh-Hant.lproj/Localizable.strings:"Failed to clone VM." = "無法複製虛擬機。";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pan93412 any suggestions here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Please mark this as ready for review once the changes are ready to be merged, thanks. |
b63ea09
to
c5ead5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that we have not decided some terms. Continue waiting PeterDaveHello for confirming.
I will merge what's here and further changes can be made in a new PR. |
Fix those using Simplified Chinese terms in Traditional Chinese characters but not properly translated.