Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Update zh-Hant localization #5652

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

PeterDaveHello
Copy link
Contributor

Fix those using Simplified Chinese terms in Traditional Chinese characters but not properly translated.

@osy osy added this to the v4.4 milestone Sep 4, 2023
@osy
Copy link
Contributor

osy commented Sep 4, 2023

@pan93412 can you comment on these changes?

Platform/zh-Hant.lproj/Localizable.strings Outdated Show resolved Hide resolved
Platform/zh-Hant.lproj/Localizable.strings Show resolved Hide resolved
Platform/zh-Hant.lproj/Localizable.strings Show resolved Hide resolved
Platform/zh-Hant.lproj/Localizable.strings Show resolved Hide resolved
Platform/zh-Hant.lproj/Localizable.strings Show resolved Hide resolved
Platform/zh-Hant.lproj/Localizable.strings Show resolved Hide resolved
@@ -1491,7 +1491,7 @@
"Share" = "分享";

/* No comment provided by engineer. */
"Share a copy of this VM and all its data." = "分享虛擬機和其所有資料的拷貝。";
"Share a copy of this VM and all its data." = "分享虛擬機和其所有資料的複製。";
Copy link
Contributor

@pan93412 pan93412 Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion: ❌ Prefer not changing.

Microsoft prefers "複製" for "copy"; Apple prefers "拷貝".

Apple zh_TW loc. Finder_FE.lg, L89

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it for all 複製 translation? I noticed that there are many places using "複製" in current translation, and the source strings are clone, duplicate and copy.

Copy link
Contributor

@pan93412 pan93412 Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple uses "複製" as their translation of duplicate:

    <TextItem>
      <Description> ^1 is the name of the file</Description>
      <Position>DU6_V1</Position>
      <TranslationSet>
        <base loc="en">Preparing to duplicate “^1”</base>
        <tran loc="zh-TW">正在準備複製「^1」</tran>
      </TranslationSet>
    </TextItem>

I have not found the translation Apple uses for "clone."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform/zh-Hant.lproj/Localizable.strings:"Failed to clone VM." = "無法複製虛擬機。";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pan93412 any suggestions here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Platform/zh-Hant.lproj/Localizable.strings Show resolved Hide resolved
Platform/zh-Hant.lproj/Localizable.strings Outdated Show resolved Hide resolved
README.zh-Hant.md Outdated Show resolved Hide resolved
@osy osy marked this pull request as draft September 5, 2023 03:51
@osy
Copy link
Contributor

osy commented Sep 5, 2023

Please mark this as ready for review once the changes are ready to be merged, thanks.

@PeterDaveHello PeterDaveHello marked this pull request as ready for review September 21, 2023 12:22
Copy link
Contributor

@pan93412 pan93412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that we have not decided some terms. Continue waiting PeterDaveHello for confirming.

@osy
Copy link
Contributor

osy commented Oct 4, 2023

I will merge what's here and further changes can be made in a new PR.

@osy osy merged commit c455779 into utmapp:main Oct 4, 2023
27 checks passed
@PeterDaveHello PeterDaveHello deleted the README.zh-Hant branch October 4, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants