Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: console mode #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat: console mode #23

wants to merge 1 commit into from

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Dec 7, 2022

added setMode to allow filtering logs out of production environment.

  • Implement setMode
  • Write tests

Copy link
Contributor

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🥳

Wouldn't it be nice to do it for the other functions like info, warning and success as well ?

With the error function I think its important to output it whether in development or production but with the other functions, they could benefit from this toggle

@Meldiron
Copy link
Contributor Author

@christyjacob4
Development: all
Stage: All except debugs (log)
Production: only error

Makes sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants