Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Migrate to Github Actions #29

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

faisalill
Copy link

@faisalill faisalill commented Aug 4, 2023

What's Changed:

Replaced travis.yml with suitabl .github/workflows/tests.yml

Testing Plan:

Opening a PR runs tests:
Github Actions Example: faisalill#1
Travis For the same: https://app.travis-ci.com/github/utopia-php/cli/jobs/606224762
Both Pass

Related Issue:

utopia-php/http#103

Should I include nightly version too And
phpstan is not used should it be added???

Copy link

@2002Bishwajeet 2002Bishwajeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

I guess nightly version is not required for now. For Phpstan, let's address that in separate PR after discussion

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
Remove analyze step from github actions
Change step name to Checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants