Remove PDO specific exception from interface

utopia-php · Dec 2, 2024 · e7bfd89 · e7bfd89
1 parent a13ea29
commit e7bfd89
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 16 deletions.
diff --git a/src/Database/Adapter.php b/src/Database/Adapter.php
@@ -1022,6 +1022,4 @@ abstract public function getConnectionId(): string;
      * @return array<string>
      */
     abstract public function getInternalIndexesKeys(): array;
-
-    abstract protected function processException(\PDOException $e): \Exception;
 }
diff --git a/src/Database/Adapter/MariaDB.php b/src/Database/Adapter/MariaDB.php
@@ -2379,6 +2379,20 @@ public function setTimeout(int $milliseconds, string $event = Database::EVENT_AL
         });
     }
 
+    /**
+     * @return string
+     */
+    public function getConnectionId(): string
+    {
+        $stmt = $this->getPDO()->query("SELECT CONNECTION_ID();");
+        return $stmt->fetchColumn();
+    }
+
+    public function getInternalIndexesKeys(): array
+    {
+        return ['primary', '_created_at', '_updated_at', '_tenant_id'];
+    }
+
     protected function processException(PDOException $e): \Exception
     {
         // Timeout
@@ -2419,18 +2433,4 @@ protected function processException(PDOException $e): \Exception
 
         return $e;
     }
-
-    /**
-     * @return string
-     */
-    public function getConnectionId(): string
-    {
-        $stmt = $this->getPDO()->query("SELECT CONNECTION_ID();");
-        return $stmt->fetchColumn();
-    }
-
-    public function getInternalIndexesKeys(): array
-    {
-        return ['primary', '_created_at', '_updated_at', '_tenant_id'];
-    }
 }
diff --git a/src/Database/Adapter/SQL.php b/src/Database/Adapter/SQL.php
@@ -1146,4 +1146,9 @@ public function getInternalIndexesKeys(): array
     {
         return [];
     }
+
+    protected function processException(PDOException $e): \Exception
+    {
+        return $e;
+    }
 }