Global timeouts using before query hooks #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
commented
Oct 19, 2023
| { | ||
| if ($this->getDatabase()->getAdapter()->getSupportForTimeouts()) { | ||
| static::getDatabase()->createCollection('global-timeouts'); | ||
| $this->assertEquals(true, static::getDatabase()->createAttribute('global-timeouts', 'longtext', Database::VAR_STRING, 100000000, true)); | ||
|
|
||
| for ($i = 0 ; $i <= 5 ; $i++) { | ||
| for ($i = 0 ; $i <= 20 ; $i++) { |
There was a problem hiding this comment.
Had to change this otherwise tests were failing, not sure if it's local to me, seems to be a performance win so not worried.
Context: loop iterations determine how many huge documents to insert to force a timeout when querying them
There was a problem hiding this comment.
We can make the text in the file little longer, maybe will help to get a timeout
fogelito
approved these changes
Oct 19, 2023
christyjacob4
approved these changes
Oct 19, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Allow using instance level query hooks to set timeout per database event (or all)
Test Plan
Existing tests, updated timeout test