-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Make authorization per-instance #343
Conversation
Fix: setAction method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't comment on the Base.php
diff since it's so big 😅 but do we need both the static and instance Authorization
instances there?
|
@Meldiron I mean in the test base class we have an instance var |
I cant improve this without renaming var in ~100 lines. The setup that is there still make sense - it's not Utopia-spepcfiic, but PHPUnit-specific. |
Makes auth validator instance-aware, to make it work fine with corutines server