Add check for length in Queries Validator #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogelito
reviewed
Nov 21, 2023
| @@ -51,6 +57,10 @@ public function isValid($value): bool | |||
| return false; | |||
| } | |||
|
|
|||
| if ($this->length && \count($value) > $this->length) { | |||
There was a problem hiding this comment.
Not sure we need the first since it is constructed with 0?
There was a problem hiding this comment.
@fogelito It looks like we are using 0 to mean unlimited, so when 0, \count($value) > $this->length won't be checked since 0 == false
|
Besides small comment looks ok 👍 |
abnegate
approved these changes
Nov 28, 2023
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some scenarios where we need both length and queries validation.