Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make findOne return empty document instead of false #449

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Make findOne return empty document instead of false #449

merged 1 commit into from
Sep 18, 2024

Conversation

PineappleIOnic
Copy link
Member

This PR makes findOne return an empty document instead of a false when no document is found. Tests have been updated appropriately.

@PineappleIOnic PineappleIOnic mentioned this pull request Sep 17, 2024
Merged
fogelito
fogelito reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@fogelito fogelito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Will have to merge once all dependencies are updated

@stnguyen90 stnguyen90 merged commit 0ad2eb1 into main Sep 18, 2024
14 checks passed
@stnguyen90 stnguyen90 deleted the feat-find-one-update branch September 18, 2024 04:00
@PineappleIOnic PineappleIOnic mentioned this pull request Sep 18, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogelito fogelito fogelito left review comments

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PineappleIOnic @stnguyen90 @fogelito